Add check if the button is held for the whole 5 seconds #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the button is held down to reboot the watch and not released after the reboot, the device can enter recovery mode unintentionally. This check aims to ignore the button if it is held for the entirety of the 5 second delay, implying it was held before the device started to boot and should be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the button is held down to reboot the watch and not released after the reboot, the device can enter recovery mode unintentionally. This check aims to ignore the button if it is held for the entirety of the 5 second delay, implying it was held before the device started to boot and should be ignored.
I'm not sure if the count will be exactly 3000 * 64 * 5 in this situation, or if there's a better way to address this, or if the secondary condition is needed for the restore_factory if statement... But I made a PR anyway despite a profound lack of certainty!