Initial work on adding internationalization. #417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds lv_i18n to the build, and starts to use keys to lookup text on the Settings screen. WIP, TODO: - Language selector for the settings screen - Consider building locale-specific DFU to cut down on size
Add default en-GB locale to settings. Make the checkboxes on language settings page function as radio selector.
Extended translations.md and added extract and compile scripts rather than copying commands from a readme to perform these operations. Added some basic spanish translations for the settings menu to test.
|
DFU from this branch |
|
Grainy photos of settings screen and (probably badly) translated menu. |
|
Needs rebasing, it's probably easier to do incrementally than in big batches. Definitely something that'll be part of InfiniTime at some point and this PR is a great start. |
|
Practically it's probably better to just start again with these code changes, they were quite simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #363
This commit adds lv_i18n tooling for translating user-facing strings. It also adds a new settings page to allow selecting between up to 4 languages.
Done:
[X] Language selector for the settings screen (caveat, this can only support up to 4 languages at the moment)
[X] Replace hard-coded english text with lookups (done most text I can find)
[X] Update main README for contributing translations
Known issue:
Some characters aren't rendering properly, for example
Bateríais rendering asBaterain the settings menu.Known limitation:
The settings screen will only support up to 4 languages.
TODO:
[ ] Fix rendering issues for characters outside the usual ASCII
[ ] Calculate firmware size increase due to translations
[ ] If unacceptably large, either: