Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather: Fix inverted imperial forecast temperatures #2184

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

vkareh
Copy link
Contributor

@vkareh vkareh commented Dec 6, 2024

When converting to imperial units, the min and max temperatures were incorrectly inverted, causing confusion in the display.

Fixes #2183

@vkareh vkareh force-pushed the fix-imperial-temp-order branch from 15c9c1b to ab18cf2 Compare December 6, 2024 16:10
@vkareh vkareh changed the title weather: Fix inverted imperial forecase temperatures weather: Fix inverted imperial forecast temperatures Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Build size and comparison to main:

Section Size Difference
text 372816B 0B
data 948B 0B
bss 22536B 0B

@mark9064 mark9064 added bug Something isn't working enhancement Enhancement to an existing app/feature labels Dec 6, 2024
@mark9064 mark9064 added this to the 1.16.0 milestone Dec 6, 2024
When converting to imperial units, the min and max temperatures were
incorrectly inverted, causing confusion in the display.

Fixes InfiniTimeOrg#2183
@vkareh vkareh force-pushed the fix-imperial-temp-order branch from ab18cf2 to 0cc9c9f Compare December 9, 2024 21:53
Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FintasticMan FintasticMan merged commit d69cfcf into InfiniTimeOrg:main Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather App - High temp incorrectly on bottom row when on imperial format
3 participants