Ignore old GoToRunning messages #2165
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
JF002
approved these changes
Nov 17, 2024
Yeah, I would like to simplify those states and improve the design so that those data race cannot occur anymore. Or maybe add unit test so we can ensure we won't break the sleep/wakeup feature again :) |
FintasticMan
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the recent display inversion issue (#2160)
In short DisplayApp could process a stale GoToRunning message with a GoToSleep also queued up after it, and do one LVGL iteration when the SPI is off
Verified locally by adding guards around SpiMaster that reset the device immediately if SPI is used while asleep (easiest way without a devkit)
I'm pretty confident DisplayApp state handling is sound after this change. But it's also quite overcomplicated now and I'd like to simplify it, but right before a release probably isn't a good time so I'll propose that later