Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refuse to (fail to) calibrate shake sensitivity while in sleep mode #2161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lmamane
Copy link

@lmamane lmamane commented Nov 6, 2024

No description provided.

Copy link

github-actions bot commented Nov 6, 2024

Build size and comparison to main:

Section Size Difference
text 374768B 176B
data 948B 0B
bss 63504B 0B

@mark9064 mark9064 added the enhancement Enhancement to an existing app/feature label Nov 18, 2024
@mark9064
Copy link
Member

This all looks good, but I think the calibrating variable should be refactored into a state enum instead as it's currently somewhat unintuitive and the 255 value doesn't help. Perhaps something like States {Idle, PrepareToCalibrate, Calibrating, CalibrationDisabled}? These probably aren't the best names, I haven't thought about them much. Hopefully you get the idea though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants