Skip to content

port to Font Awesome v6.6.0 #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lmamane
Copy link
Contributor

@lmamane lmamane commented Nov 2, 2024

Le me know whether that change is welcome.

It started because I wanted some icons from v6 for an app I'm writing, and I thought it would be cleaner to port to v6 rather than keep both v5 and v6 in the source tree. If for some reason you prefer to keep v5, no problem, we/I can ship both v5 and v6 in the source tree and pick some symbols from v5 and other symbols from v6. That would make the source tree larger, but as far as I understand not the built firmware.

  • I dropped 0xf00c (single checkmark) because it seemed to be unused. The symbol named "check" is actually a single checkmark.
  • The codepoint for tachymeter-alt in v5 corresponds to a quite different icon in v6; I changed to the codepoint in v6 for a very similar icon named gauge-high
  • the home codepoint in v5 has a chimney but doesn't have in v6 (named house in v6), so I changed to the v6 codepoint for house-chimney to keep the icon as similar as possible; also the roof is not separated by a blank from the body of the house, that is thus a small graphical change.

@lmamane lmamane marked this pull request as draft November 2, 2024 17:08
@lmamane
Copy link
Contributor Author

lmamane commented Nov 2, 2024

Darn, I forgot the weather icons... building them must be disabled in my build, because it builds on my computer... Coming back soon with a revised one.

Copy link

github-actions bot commented Nov 2, 2024

Build size and comparison to main:

Section Size Difference
text 375656B -28B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@lmamane lmamane marked this pull request as ready for review November 2, 2024 17:21
@mark9064 mark9064 added the maintenance Background work label Nov 18, 2024
@mark9064
Copy link
Member

Need to test this but looks good on principle, agree that there is no need to keep v5 around so a migration to v6 makes sense

@mark9064
Copy link
Member

mark9064 commented Dec 1, 2024

Booted on my watch today - all icons seem to be present and working. Any chance you could do a run with InfiniSim and upload some screenshots of the difference? If not I can make some, but I don't have the time today

@tituscmd
Copy link
Contributor

Friendly little nudge :)

Just tried this on my devkit and I haven't had any issues either.

@tituscmd
Copy link
Contributor

I dropped 0xf00c (single checkmark) because it seemed to be unused. The symbol named "check" is actually a single checkmark.

This icon is actually used for LV_SYMBOL_OK, used in the square checkboxes right here:
image
Without it, it just shows a green box without any checkmark, so it should be kept in the code.

@tituscmd
Copy link
Contributor

tituscmd commented Jun 11, 2025

Any chance you could do a run with InfiniSim and upload some screenshots of the difference? If not I can make some, but I don't have the time today

Since I'm already working with it right now, here's some notable differences - Left side is before, right side is after:
(This is a custom fork of mine. The settings menus might be renamed and reordered, but the icons are the default ones)

Screenshot 2025-06-11 at 17-58-01 InfiniEmu Screenshot 2025-06-11 at 17-56-23 InfiniEmu

Screenshot 2025-06-11 at 17-59-16 InfiniEmu Screenshot 2025-06-11 at 18-00-07 InfiniEmu

Screenshot 2025-06-11 at 17-58-24 InfiniEmu Screenshot 2025-06-11 at 17-57-04 InfiniEmu

@lmamane
Copy link
Contributor Author

lmamane commented Jun 11, 2025

Since I'm already working with it right now, here's some notable differences - Left side is before

Yes, the house and tachometer things were described in my initial message.

@tituscmd
Copy link
Contributor

Since I'm already working with it right now, here's some notable differences - Left side is before

Yes, the house and tachometer things were described in my initial message.

Yep! I put them in there so others can see exactly what you're talking about 😄

@lmamane
Copy link
Contributor Author

lmamane commented Jun 11, 2025

This icon is actually used for LV_SYMBOL_OK

I don't find the bit of code that does that, but indeed. I've been running with this modification for months but didn't cotton on there was supposed to be a checkmark. Added it back.

* Changed codepoint for tachometer to most similar icon in v6. Small
  remaining difference: the circle is not cut off at the bottom but
  whole.

* Changed codepoint for home to most similar icon in v6, that is with
  chimney. Small remaining difference: the roof is not separated by
  thin blank line from the body of the house.
@lmamane
Copy link
Contributor Author

lmamane commented Jun 11, 2025

rebased on current main, resolved merge conflicts

Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked weather icons but rest looks good to me. Always good to keep on the latest versions

@tituscmd
Copy link
Contributor

Haven't checked weather icons but rest looks good to me. Always good to keep on the latest versions

Fwiw, I'm running this on my main device now and every weather symbol so far has been represented without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Background work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants