port to Font Awesome v6.6.0 #2154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn, I forgot the weather icons... building them must be disabled in my build, because it builds on my computer... Coming back soon with a revised one. |
|
Build size and comparison to main:
|
* Removed 0xf00c (single checkmark) since it seems unused; the symbol named "check" on src/displayapp/screens/Symbols.h is actually a double checkmark. * Changed codepoint for tachometer to most similar icon in v6. Small remaining difference: the circle is not cut off at the bottom but whole. * Changed codepoint for home to most similar icon in v6, that is with chimney. Small remaining difference: the root is not separated by thin blank line from the body of the house.
|
Need to test this but looks good on principle, agree that there is no need to keep v5 around so a migration to v6 makes sense |
|
Booted on my watch today - all icons seem to be present and working. Any chance you could do a run with InfiniSim and upload some screenshots of the difference? If not I can make some, but I don't have the time today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le me know whether that change is welcome.
It started because I wanted some icons from v6 for an app I'm writing, and I thought it would be cleaner to port to v6 rather than keep both v5 and v6 in the source tree. If for some reason you prefer to keep v5, no problem, we/I can ship both v5 and v6 in the source tree and pick some symbols from v5 and other symbols from v6. That would make the source tree larger, but as far as I understand not the built firmware.