-
-
Notifications
You must be signed in to change notification settings - Fork 1k
port to Font Awesome v6.6.0 #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Darn, I forgot the weather icons... building them must be disabled in my build, because it builds on my computer... Coming back soon with a revised one. |
Build size and comparison to main:
|
Need to test this but looks good on principle, agree that there is no need to keep v5 around so a migration to v6 makes sense |
Booted on my watch today - all icons seem to be present and working. Any chance you could do a run with InfiniSim and upload some screenshots of the difference? If not I can make some, but I don't have the time today |
Friendly little nudge :) Just tried this on my devkit and I haven't had any issues either. |
Yes, the house and tachometer things were described in my initial message. |
Yep! I put them in there so others can see exactly what you're talking about 😄 |
I don't find the bit of code that does that, but indeed. I've been running with this modification for months but didn't cotton on there was supposed to be a checkmark. Added it back. |
* Changed codepoint for tachometer to most similar icon in v6. Small remaining difference: the circle is not cut off at the bottom but whole. * Changed codepoint for home to most similar icon in v6, that is with chimney. Small remaining difference: the roof is not separated by thin blank line from the body of the house.
rebased on current main, resolved merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked weather icons but rest looks good to me. Always good to keep on the latest versions
Fwiw, I'm running this on my main device now and every weather symbol so far has been represented without issue. |
Le me know whether that change is welcome.
It started because I wanted some icons from v6 for an app I'm writing, and I thought it would be cleaner to port to v6 rather than keep both v5 and v6 in the source tree. If for some reason you prefer to keep v5, no problem, we/I can ship both v5 and v6 in the source tree and pick some symbols from v5 and other symbols from v6. That would make the source tree larger, but as far as I understand not the built firmware.