Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrono: Resolve TODOs related to C++20 chrono feats #2016

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chrono: Resolve TODOs related to C++20 chrono feats #2016

merged 1 commit into from
Mar 14, 2024

Conversation

FintasticMan
Copy link
Member

There are a couple more TODOs related to using std::chrono::year, which was added in C++20, but not supported by GCC 10 it seems.

@github-actions GitHub Actions
Copy link

Build size and comparison to main:

Section Size Difference
text 373300B 128B
data 940B 0B
bss 63516B 0B

JF002
JF002 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@JF002 JF002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[...] but not supported by GCC 10 it seems.

We might want to update our version of GCC to fix those issues and benefit from more recent compiler :)

@JF002 JF002 added this to the 1.15.0 milestone Mar 14, 2024
@JF002 JF002 merged commit 7dbb8f5 into main Mar 14, 2024
7 checks passed
@FintasticMan FintasticMan deleted the cpp20_todos branch March 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF002 JF002 JF002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FintasticMan @JF002