BatteryIcon: Change color with charge percentage #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
|
Nice idea, I like it a lot! 😊 |
vkareh
force-pushed
the
battery-icon-colors
branch
from
bfaaffd to
b7a6ddc
Compare
|
@minacode That's a brilliant suggestion! I've updated the code and added a new screenshot - looks way better, thanks! |
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
9eaf40e to
8e61a5d
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
7083ce0 to
a850f49
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
3 times, most recently
from
ec452d0 to
20a0843
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
559832f to
de3ca3a
Compare
|
I love this change. Thank you. |
vkareh
force-pushed
the
battery-icon-colors
branch
from
de3ca3a to
7e86e85
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
7e86e85 to
a238940
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
a238940 to
0178441
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
0178441 to
f5f160f
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
f5f160f to
b534fa2
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
b534fa2 to
a570644
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
8dee72a to
dfa3c8e
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
dfa3c8e to
1353e94
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
7a27ce7 to
f39c176
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
f39c176 to
a9aa092
Compare
JustScott
added a commit
to JustScott/InfiniTime
that referenced
this pull request
Oct 3, 2024
+ Reorder code to match the widgets order in the UI. + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore.
JustScott
added a commit
to JustScott/InfiniTime
that referenced
this pull request
Oct 4, 2024
+ Reorder code to match the widgets order in the UI. + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore.
headblockhead
added a commit
to headblockhead/InfiniTime
that referenced
this pull request
Oct 4, 2024
* Remove unused pointer to DisplayApp member variables (InfiniTimeOrg#2125) In the screens that use `DisplayApp *app` and pass it to a child item, or use the reference just in the constructor. Afterwards the `app` member is not used. So remove it from the private member variables. Completely remove `app` parameter from `SettingDisplay` constructor as it is unused. * MusicService: add missing includes for TickType_t and xTaskGetTickCount (InfiniTimeOrg#2130) Add `FreeRTOS.h` include for the directly used data type `TickType_t` in the header and the function `xTaskGetTickCount` from FreeRTOS's `task.h` * Improved the Terminal Watchfaces UI + Reorder code to match the widgets order in the UI. + Use InfintimeTheme Colors instead of hardcoded hex values + Added a new InfinitimeTheme color: gray, using it to turn certain values gray when they contain no data + Implement @vkareh's [variable battery icon](InfiniTimeOrg#1964) color to the battery percentage text. + Replaced the 'You have mail.' notification message with the message '[1]+ Notify' to better fit the terminal lore. --------- Co-authored-by: NeroBurner <[email protected]> Co-authored-by: JustScott <[email protected]>
vkareh
force-pushed
the
battery-icon-colors
branch
2 times, most recently
from
0999c86 to
0033739
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
0033739 to
372455e
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
372455e to
d063633
Compare
vkareh
force-pushed
the
battery-icon-colors
branch
from
d063633 to
219128c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silly little change to dynamically color the battery based on the charge left.