Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartrate app displays --- instead of 000 #1887

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

KaffeinatedKat
Copy link
Contributor

Fixes #1881, when the heartrate data is not clear, or there is no measurement, display --- instead of 000

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Build size and comparison to main:

Section Size Difference
text 377616B 0B
data 940B 0B
bss 63492B 0B

Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes it more clear to the user what the situation is.

@FintasticMan FintasticMan requested a review from a team November 17, 2023 13:11
@FintasticMan FintasticMan added the UI/UX User interface/User experience label Nov 17, 2023
@mark9064
Copy link
Member

Does exactly what it says on the tin, haven't had any issues. Seems good to go UX wise to me

@NeroBurner NeroBurner merged commit 6b5235c into InfiniTimeOrg:main Apr 12, 2024
7 checks passed
Eve1374 pushed a commit to Eve1374/InfiniTime that referenced this pull request May 30, 2024
@FintasticMan FintasticMan added this to the 1.15.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX User interface/User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heartrate Value jumps to 000
4 participants