-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show alarm controller state in status icons #1884
base: main
Are you sure you want to change the base?
Conversation
Build checks have not completed. Possible reasons for this are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this feature! :)
You should be very safe to test this on a sealed device (speaking from experience).
If something goes wrong, which shouldn't happen, you can always:
- reboot to get back to your last firmware (don't verify your debug flash of course)
- hold the button pressed until the color changed twice during boot to get to the fallback firmware and update your watch from there.
I have also tested the feature on hardware. |
I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon. I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request. |
Ah, I forgot it was already the icon for the alarm app.
Sorry about that.
…On November 9, 2023 9:30:26 AM CST, Jozef Mlich ***@***.***> wrote:
I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.
I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.
--
Reply to this email directly or view it on GitHub:
#1884 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
This should be rebased against |
@jmlich I'd like to give this change a try, would you mind rebasing this changeset against the current state of |
Rebased to recent main |
I would like to know if the alarm is active on Watch Face Digital screen.
I made an prototype with InfiniSim and it looks that it works as expected:
However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.