Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show alarm controller state in status icons #1884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Oct 8, 2023

I would like to know if the alarm is active on Watch Face Digital screen.

I made an prototype with InfiniSim and it looks that it works as expected:

InfiniSim_2023-10-08_113731 infinisim

However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

Copy link
Contributor

@minacode minacode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this feature! :)

You should be very safe to test this on a sealed device (speaking from experience).
If something goes wrong, which shouldn't happen, you can always:

  • reboot to get back to your last firmware (don't verify your debug flash of course)
  • hold the button pressed until the color changed twice during boot to get to the fallback firmware and update your watch from there.

src/displayapp/widgets/StatusIcons.cpp Outdated Show resolved Hide resolved
@jmlich
Copy link
Contributor Author

jmlich commented Oct 21, 2023

I have also tested the feature on hardware.

@LinuxinaBit
Copy link

I like this, but I think the icon has a little too much filled space and the simple circle isn’t as defined as a more standard alarm icon:
image
Of course these might not work with a resolution that small, but I’m sure something similar could…

@jmlich
Copy link
Contributor Author

jmlich commented Nov 9, 2023

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.

@LinuxinaBit
Copy link

LinuxinaBit commented Nov 9, 2023 via email

@vkareh
Copy link
Contributor

vkareh commented Feb 12, 2024

This should be rebased against main and updated to reflect the new icon from #1996

@rnwgnr
Copy link

rnwgnr commented Aug 15, 2024

@jmlich I'd like to give this change a try, would you mind rebasing this changeset against the current state of main?

@jmlich
Copy link
Contributor Author

jmlich commented Aug 24, 2024

Rebased to recent main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants