Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open battery app when charging #1876

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

KaffeinatedKat
Copy link
Contributor

This change makes the battery info app open upon putting the watch on the charger, if the current app is the clock (as to not close any app that might be running). If the watch is taken off the charger while the battery app is open, it returns to the clock.

This pr also removes the vibration while charging if the battery app is opened/closed, which should help prevent #724.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Build size and comparison to main:

Section Size Difference
text 376816B 16B
data 940B 0B
bss 63420B 0B

@LinuxinaBit
Copy link

This might be better as kind of popup, like a notification with that 5 second timeout.

Copy link
Contributor

@vkareh vkareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplicity of this code. Doesn't add much overhead and works well (have been using it for a few months with no issues) while improving user expectation upon plugging/unplugging.

@vkareh
Copy link
Contributor

vkareh commented Feb 9, 2024

I've included this patchset as part of a larger configuration that allows auto-opening apps based on certain events: https://github.com/InfiniTimeOrg/InfiniTime/pull/2004/commits

This makes this feature optional/configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants