-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open battery app when charging #1876
base: main
Are you sure you want to change the base?
Conversation
Build size and comparison to main:
|
This might be better as kind of popup, like a notification with that 5 second timeout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the simplicity of this code. Doesn't add much overhead and works well (have been using it for a few months with no issues) while improving user expectation upon plugging/unplugging.
I've included this patchset as part of a larger configuration that allows auto-opening apps based on certain events: https://github.com/InfiniTimeOrg/InfiniTime/pull/2004/commits This makes this feature optional/configurable. |
This change makes the battery info app open upon putting the watch on the charger, if the current app is the clock (as to not close any app that might be running). If the watch is taken off the charger while the battery app is open, it returns to the clock.
This pr also removes the vibration while charging if the battery app is opened/closed, which should help prevent #724.