Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchFaceDigital: Add weather display #1856

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

vkareh
Copy link
Contributor

@vkareh vkareh commented Sep 7, 2023

If weather is available, display the cloud icon and temperature.

Screenshot at 2023-09-07 16-37-56

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Build size and comparison to main:

Section Size Difference
text 373092B 464B
data 940B 0B
bss 63516B 0B

@vkareh vkareh force-pushed the face-digital-weather branch from 5d4e321 to 82e7962 Compare October 25, 2023 17:51
@vkareh vkareh force-pushed the face-digital-weather branch from 82e7962 to 200c8df Compare November 23, 2023 18:09
@vkareh vkareh force-pushed the face-digital-weather branch from 200c8df to c15cc2a Compare December 1, 2023 16:21
@vkareh vkareh force-pushed the face-digital-weather branch 2 times, most recently from f215dd0 to 78ddaa2 Compare January 4, 2024 14:55
@vkareh
Copy link
Contributor Author

vkareh commented Jan 4, 2024

Rebased against main and adapted to work with the SimpleWeatherService.

Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

src/displayapp/screens/WatchFaceDigital.cpp Outdated Show resolved Hide resolved
@vkareh vkareh force-pushed the face-digital-weather branch from 78ddaa2 to 5edb4e8 Compare January 4, 2024 17:44
@FintasticMan FintasticMan requested a review from a team January 4, 2024 18:44
@vkareh vkareh force-pushed the face-digital-weather branch 3 times, most recently from d024057 to 535bdda Compare January 15, 2024 13:59
@vkareh vkareh force-pushed the face-digital-weather branch from 535bdda to bad760c Compare January 16, 2024 21:47
If weather is available, display the cloud icon and temperature.
@vkareh vkareh force-pushed the face-digital-weather branch from bad760c to 19e0865 Compare January 23, 2024 14:46
@NeroBurner NeroBurner added this to the 1.15.0 milestone Jan 23, 2024
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FintasticMan FintasticMan merged commit 2135e12 into InfiniTimeOrg:main Jan 23, 2024
7 checks passed
@vkareh vkareh deleted the face-digital-weather branch January 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants