Update InfiniTime #146
Closed
Update InfiniTime #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
D'oh, it looks like these changes were made in #145 in the time it took me to put together the PR! |
|
That happens sometimes 😉. To me your PR looks good. The title could be a little more descriptive, but at least the description then tells it all. You even split the fixes for two problems in different commits (I didnt't 😉). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates InfiniSim to the current tip of InfiniTime 'main' and includes a couple of minor breakages in the simulator build.
This is my first time contributing so apologies if my changes are improperly formatted/divided. I've attempted to follow the guidelines and what I've seen in the existing commit logs but would be grateful for any additional feedback.