Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMP0153 for newer CMake versions #133

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix CMP0153 for newer CMake versions #133

merged 1 commit into from
Dec 11, 2023

Conversation

minacode
Copy link
Contributor

I could not build the simulator because of this.

This PR updates the CMake file to the newer function.

FintasticMan
FintasticMan approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@FintasticMan FintasticMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one question.

CMakeLists.txt Show resolved Hide resolved
NeroBurner
NeroBurner approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NeroBurner NeroBurner merged commit 39b9b17 into InfiniTimeOrg:main Dec 11, 2023
1 check passed
@minacode minacode deleted the fix-call branch December 11, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FintasticMan FintasticMan FintasticMan approved these changes

@NeroBurner NeroBurner NeroBurner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minacode @NeroBurner @FintasticMan