-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused SSL Registry and an empty unit #293
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of any known uses of RegisterSSL()
/GSSLRegistry
. Indy itself does not make use of GSSLRegistry
for anything, other than to register the SSLIOHandler
classes in it, but maybe external tools make use of it? I don't know. This may or may not be dead code (it probably is, though).
Turns out, you and I have had this conversation before, a year ago on Gitter. Guess nothing came of it at the time.
Rather than removing this code outright now, I would suggest marking it as 'deprecated' for now, and then I will remove it in Indy 11.
Maybe it's time to remove .NET too? |
Even if external tools make use of it, they could still create an own list and register the |
Support for .NET and pre-Unicode compilers is already slated to be removed in Indy 11 (#131 and #132). It has already been implemented - what is currently in the "Restructure" branch in GitHub will eventually be rebranded as Indy 11, once some pending things have been finalized and the branch is updated with the latest code from my working copy. |
Small code clean ups to remove unused GSSLRegistry
and the empty unit IdServerIOHandlerSSLOpenSSL.