Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused SSL Registry and an empty unit #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mezen
Copy link
Contributor

@mezen mezen commented Mar 17, 2020

Small code clean ups to remove unused GSSLRegistry

and the empty unit IdServerIOHandlerSSLOpenSSL.

@mezen mezen changed the title Removed empty unit Removed unused SSL Registry and an empty unit Mar 17, 2020
Copy link
Member

@rlebeau rlebeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of any known uses of RegisterSSL()/GSSLRegistry. Indy itself does not make use of GSSLRegistry for anything, other than to register the SSLIOHandler classes in it, but maybe external tools make use of it? I don't know. This may or may not be dead code (it probably is, though).

Turns out, you and I have had this conversation before, a year ago on Gitter. Guess nothing came of it at the time.

Rather than removing this code outright now, I would suggest marking it as 'deprecated' for now, and then I will remove it in Indy 11.

@JNPSoftware
Copy link

Maybe it's time to remove .NET too?

@mezen
Copy link
Contributor Author

mezen commented Mar 18, 2020

Even if external tools make use of it, they could still create an own list and register the SLLIOHandler.

@rlebeau
Copy link
Member

rlebeau commented Mar 18, 2020

Support for .NET and pre-Unicode compilers is already slated to be removed in Indy 11 (#131 and #132). It has already been implemented - what is currently in the "Restructure" branch in GitHub will eventually be rebranded as Indy 11, once some pending things have been finalized and the branch is updated with the latest code from my working copy.

@rlebeau rlebeau added Type: Enhancement Issue is proposing a new feature/enhancement Element: I/O Handlers Issues related to TIdIOHandler and descendants Element: SSL/TLS Issues related to SSL/TLS handling, TIdSSLIOHandlerSocketBase and descendants labels May 20, 2021
@rlebeau rlebeau added this to the Indy 11 - Maintenance Release milestone Feb 1, 2023
@rlebeau rlebeau self-assigned this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Element: I/O Handlers Issues related to TIdIOHandler and descendants Element: SSL/TLS Issues related to SSL/TLS handling, TIdSSLIOHandlerSocketBase and descendants Type: Enhancement Issue is proposing a new feature/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants