-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few misc tidy-ups #85
Conversation
I disagree with needing a return type annotation in tests since they all, but design, return The |
@AdrianDAlessandro Ahhh ok. I wondered what that The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
Just a note. I don't think we should remove ruff as a dev dependency. We can't assume people use VScode and my own dev setup for instance presumes that the linters are available in the project venv. |
Turns out it doesn't work with |
@cc-a Ahh ok. I'll put it back then. Also, I've noticed |
It does work, but you have to do
It might be installed along with |
Aha. Right on both counts @AdrianDAlessandro |
While working on a new template using cookiecutter, I found a few small issues with the current template:
__init__.py
file intests
folderimportlib
to find the package version in a more robust wayruff
from dev dependencies (thepre-commit
hook and VS Code extension both use bundled versions)