Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve run.sh script #44

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Improve run.sh script #44

merged 1 commit into from
Jan 24, 2025

Conversation

work4cs
Copy link
Collaborator

@work4cs work4cs commented Jan 23, 2025

  • Improve run.sh script with explanation comments to better show the whole process of generating the score on benchmark
  • Remove the paths from our server.

@work4cs work4cs requested a review from egrace479 January 23, 2025 21:23
@work4cs work4cs self-assigned this Jan 23, 2025
egrace479
egrace479 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also add a note about this file and what it does in the README? You can do that in a separate PR, having it and pointing from the issue is priority.

@work4cs work4cs merged commit f5725f0 into main Jan 24, 2025
@work4cs
Copy link
Collaborator Author

work4cs commented Jan 24, 2025

Looks good. Could you also add a note about this file and what it does in the README? You can do that in a separate PR, having it and pointing from the issue is priority.

The README updated in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egrace479 egrace479 egrace479 approved these changes

Assignees

@work4cs work4cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@work4cs @egrace479