fix: Normalize course id when received with LTI 1.1 context_label (#433)

src/illumidesk/authenticators/authenticator.py

@@ -161,7 +161,7 @@ async def authenticate(self, handler: BaseHandler, data: Dict[str, str] = None)
             # runs as a docker container we need to normalize the string so we can use it
             # as a container name.
             if 'context_label' in args and args['context_label']:
-                course_id = args['context_label']
+                course_id = lti_utils.normalize_string(args['context_label'])
                 self.log.debug('Course context_label normalized to: %s' % course_id)
             else:
                 raise HTTPError(400, 'Course label not included in the LTI request')

src/tests/illumidesk/authenticators/test_lti11_authenticator.py

@@ -138,6 +138,33 @@ async def test_authenticator_uses_lti_utils_normalize_string(
             assert mock_normalize_string.called
 
 
+@pytest.mark.asyncio
+async def test_authenticator_uses_lti_utils_normalize_string_for_context_label(
+    make_lti11_success_authentication_request_args, gradesender_controlfile_mock, mock_nbhelper
+):
+    """
+    Ensure that we call the normalize string method with the LTI11Authenticator when the course id is
+    obtained from the context_label argument.
+    """
+    with patch.object(LTI11LaunchValidator, 'validate_launch_request', return_value=True):
+        with patch.object(LTIUtils, 'normalize_string', return_value='foobar') as mock_normalize_string:
+            authenticator = LTI11Authenticator()
+            handler = Mock(spec=RequestHandler)
+            request = HTTPServerRequest(
+                method='POST',
+                connection=Mock(),
+            )
+            handler.request = request
+
+            handler.request.arguments = make_lti11_success_authentication_request_args('context_label')
+            handler.request.get_argument = lambda x, strip=True: make_lti11_success_authentication_request_args(
+                'context_label'
+            )[x][0].decode()
+
+            _ = await authenticator.authenticate(handler, None)
+            assert mock_normalize_string.called
+
+
 @pytest.mark.asyncio
 @patch('pathlib.Path.mkdir')
 async def test_authenticator_uses_lti_grades_sender_control_file_with_student_role(

src/tests/illumidesk/conftest.py

@@ -539,7 +539,7 @@ def _make_lti11_basic_launch_args(
 @pytest.fixture(scope='function')
 def make_lti11_success_authentication_request_args():
     def _make_lti11_success_authentication_request_args(
-        lms_vendor: str = 'canvas', role: str = 'Instructor'
+        lms_vendor: str = 'canvas', role: str = 'Instructor',
     ) -> Dict[str, str]:
         """
         Return a valid request arguments make from LMS to our tool (when authentication steps were success)