Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Rename Cache Implementation #10

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

IlicMiljan
Copy link
Owner

@IlicMiljan IlicMiljan commented Mar 10, 2024

Description of Changes

This PR involves renaming the ItemPoolCompatibleCache class within the library to CacheItemPoolAdapter. The renaming reflects a more intuitive understanding of the class's functionality as an adapter for cache item pools.

Corresponding unit test class names have also been updated to match the new naming convention.

How Has This Been Tested?

The PR includes updates to unit tests to reflect the classes' renaming, ensuring that the functionality remains consistent and reliable with the new class names.

Checklist

Please confirm the following:

  • I have tested my changes and corrected any errors.
  • I have documented my changes if necessary.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (70ead66) to head (6ee4f6a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #10   +/-   ##
=========================================
  Coverage     96.11%   96.11%           
  Complexity       63       63           
=========================================
  Files            17       17           
  Lines           206      206           
=========================================
  Hits            198      198           
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlicMiljan IlicMiljan merged commit de2a40a into main Mar 10, 2024
1 check passed
@IlicMiljan IlicMiljan deleted the rename-cache-implementation branch March 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants