Separate charts in build #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstratkovinfrag
changed the title
turbobobbytraykov
requested changes
Aug 19, 2025
| dirName=$(basename "$subdirectory") | ||
| cd "$subdirectory" | ||
| echo "Calling npm version command for $dirName" |
There was a problem hiding this comment.
Use a more meaningful message such as:
"Use npm version to set the version we want people to see for the project"
| fi | ||
| done | ||
| # - task: PowerShell@2 |
There was a problem hiding this comment.
This step is commented out - if it's not used, remove it.
turbobobbytraykov
requested changes
Aug 19, 2025
| Get-ChildItem -Include "*.tsx","*.ts" -Recurse | ` | ||
| ForEach { | ||
| (Get-Content $_.PSPath | ForEach { | ||
| ($_ -replace '(from|import)\s?[''"](igniteui-webcomponents-[^''"]+|dockmanager.*)[''"]', '$1 "@infragistics/$2"') |
There was a problem hiding this comment.
Can you extend the loop by adding a message as to which file is being processed at the moment?
Also, right now we have no idea if these replace statements are actually found in a specific file.
It may turn out that the regex patterns are not well-suited for a future situation and we don't find out about it from the execution log.
turbobobbytraykov
approved these changes
Aug 19, 2025
turbobobbytraykov
deleted the
rstratkov/wc-grid-examples-manual-trial-to-licensed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include charts to build artifact and fix trial to licensed to not use igniteui-cli due to incompatibility.