Move Wayland client logic into WS::BaseBackend, WS::BaseTarget classes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zdobersek
commented
Jul 28, 2019
zdobersek
commented
Move the Wayland client logic from EGL rendering backends and targets into standalone WS::BaseBackend and WS::BaseTarget classes, leaving only the EGL specifics inside the Backend and Target classes implementing the EGL-oriented renderer_backend_egl and renderer_backend_egl_target interfaces. This makes the Wayland client code possible to reuse for backends and targets targeting other rendering APIs. Two notable changes in behavior: - The wl_display object is now destroyed through wl_display_disconnect(). - We destroy the wl_registry object as soon as it's not necessary anymore.
aperezdc
approved these changes
Jul 29, 2019
|
|
||
| BaseBackend::BaseBackend(int hostFD) | ||
| { | ||
| m_wl.display = wl_display_connect_to_fd(hostFD); |
There was a problem hiding this comment.
Ah, now that I see this being moved it makes me think that we should add some error checking in case wl_display_connect_to_fd() and at least log the error instead of continuing silently. Anyway, this PR is just moving the code around so I wold rather have that as a cleanup later on—I just opened issue #66 to not forget about it.
| void BaseTarget::requestFrame() | ||
| { | ||
| if (m_wl.frameCallback) | ||
| std::abort(); |
There was a problem hiding this comment.
In a similar vein, g_error() would be nicer as it would also print a message, but this PR is only moving code around, so let's use #68 to track doing this later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.