Conversation
nilmerg
requested changes
Nov 28, 2025
modules/monitoring/library/Monitoring/Backend/Ido/Query/EventgridQuery.php
Outdated
Show resolved
Hide resolved
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
Outdated
Show resolved
Hide resolved
Member
|
Also, the changes to the monitoring module seem implausible to be complete. You already acknowledged in person that you didn't test it yet since you don't have the IDO enabled/configured. Please talk to @lippserd whether that's necessary to begin with. |
Member
|
The fact that 730af4c doesn't conditionally call |
lippserd
force-pushed
the
replace-deprecated-features
branch
3 times, most recently
from
bcade4e to
d5c87b1
Compare
BastianLedererIcinga
force-pushed
the
replace-deprecated-features
branch
from
21293ec to
d5c87b1
Compare
BastianLedererIcinga
force-pushed
the
replace-deprecated-features
branch
2 times, most recently
from
03995b3 to
be1b54a
Compare
1 task
lippserd
force-pushed
the
replace-deprecated-features
branch
from
be1b54a to
29264ff
Compare
lippserd
previously approved these changes
Mar 10, 2026
Since PHP 8.4 implicitly nullable parameter types are deprecated. Normalize scoped PHPDoc for nullable-parameter updates: use `?Type` instead of `Type|null`, remove column alignment, and indent continuation lines with 2 spaces. Co-authored-by: "Eric Lippmann <eric.lippmann@icinga.com>"
`ReflectionProperty::setAccessible()` has had no effect since PHP 8.1, as all properties are accessible via reflection by default. The method is deprecated as of PHP 8.5.
The backtick operator is deprecated as of PHP 8.5.
Calling `array_key_exists()` with a `null` key is deprecated as of PHP 8.5.
PHP 8.4 has deprecated `session.sid_bits_per_character` along with `session.sid_length`, as part of a broader effort to standardize session ID generation for improved security and interoperability.
lippserd
force-pushed
the
replace-deprecated-features
branch
from
29264ff to
e0dd270
Compare
Member
|
I will push an upgrading entry for the IPL requirement after I have determined which version we will use for introducing backward-incompatible changes, and then merge the PR. |
lippserd
force-pushed
the
replace-deprecated-features
branch
from
e0dd270 to
1a4719b
Compare
Forward compatibility fix: `ipl\Html` will introduce strict types, which declares `$name` as string. Passing `null` will result in a `TypeError` once strict types are enforced.
PHP 8.1 deprecated passing `null` to non-nullable parameters in built-in functions (deprecated in 8.1, will become a `TypeError` in 9.0).
Replace deprecated `PDO::MYSQL_*` constant usage with the driver-specific `Pdo\Mysql::ATTR_*` constants introduced in PHP 8.4. This prepares the code for PHP 8.5, where accessing MySQL driver constants through the generic `PDO` class is deprecated. This change requires a compatibility shim on older PHP versions to provide `Pdo\Mysql` for runtimes that do not expose the driver-specific class yet. The shim is provided in `ipl-sql`. As a consequence, the required version of the Icinga PHP library has been raised.
Remove errors no longer reported. Since PHP 7.x is no longer supported, remove the 7.x baseline. It is now no longer necessary to have multiple baseline files.
lippserd
force-pushed
the
replace-deprecated-features
branch
from
1a4719b to
9bd53ac
Compare
lippserd
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4
session.sid_bits_per_characterfor PHP < 8.4Migration Docs
PHP 8.5
ReflectionProperty::setAccessible()callsshell_exec()nullas key inarray_key_exists()nullto non-nullable parameters in built-in functionsPdo\Mysqldriver-specific constantsMigration Docs
Other compatibility fixes
nullasipl\Htmlform element$nameresolves #5269
resolves #5450
requires Icinga/ipl-sql#99