Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MariaDB to requirements #5246

Closed
wants to merge 1 commit into from

Conversation

robertsilen
Copy link
Contributor

add MariaDB to requirements, as discussed in #5237

Copy link

cla-bot bot commented Aug 15, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @robertsilen

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 15, 2024
@nilmerg nilmerg changed the base branch from release/v2.8.0 to main August 15, 2024 11:07
@nilmerg
Copy link
Member

nilmerg commented Aug 15, 2024

Thank you :D Though, I'm not sure why you picked such an old state. Please adjust this based on main.

@robertsilen
Copy link
Contributor Author

robertsilen commented Aug 15, 2024

The 2.8 installation doc implicitly mentions MySQL in the requirements, so I was trying to add MariaDB there, but looks like this PR is going into main now.

For main's current installation doc I suggest this PR: #5247

Sorry, not sure how to best merge or replace these PRs. This PR can be closed if you are not accepting it into 2.8?

@nilmerg
Copy link
Member

nilmerg commented Aug 15, 2024

2.8 is not supported anymore and as such, changes won't be released nor be included in our official documentation.

@nilmerg nilmerg closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants