-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update font family stacks #5241
base: main
Are you sure you want to change the base?
Conversation
Sounds passive-aggressive to me and I want to know which change you're talking about? The lines you touch here were last changed about a decade ago. |
cb9c8c6
to
f230984
Compare
It wasn't meant that way. I stumbled over it and was just wondering, why we aren't using the default OS fonts for the monospaced font stack. But you're right, the change for the fixed family seems to not having been changed. I was convinced, that when we updated the regular font stack, we also did for the fixed font-family, which was wrong. Hopefully that clarifies it. Besides that, I'm still convinced that it made sense to do so now. There's also a relatively new value called It should also be sufficiently supported in non bleeding edge browsers. |
f230984
to
cb9c8c6
Compare
cb9c8c6
to
c1b6f24
Compare
Okay. I was just triggered by this allegation that wasn't backed by any references. Anyway. Supporting bleeding-edge font aliases is fine, there are fallbacks for this reason. |
Quickly tested this and discussed this with @flourish86. Seems fine now, though I noticed that |
Not sure who changed the font stack for the fixed font and why. But it seems like a good opportunity to update our default font-stacks. ✌️
https://css-tricks.com/snippets/css/system-font-stack/