Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update font family stacks #5241

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

flourish86
Copy link
Contributor

Not sure who changed the font stack for the fixed font and why. But it seems like a good opportunity to update our default font-stacks. ✌️

https://css-tricks.com/snippets/css/system-font-stack/

@cla-bot cla-bot bot added the cla/signed label Aug 6, 2024
@nilmerg
Copy link
Member

nilmerg commented Aug 7, 2024

Not sure who changed the font stack for the fixed font and why.

Sounds passive-aggressive to me and I want to know which change you're talking about? The lines you touch here were last changed about a decade ago.

@flourish86 flourish86 force-pushed the fix/update-font-family-stacks branch 2 times, most recently from cb9c8c6 to f230984 Compare August 8, 2024 09:23
@flourish86
Copy link
Contributor Author

Sounds passive-aggressive to me …

It wasn't meant that way. I stumbled over it and was just wondering, why we aren't using the default OS fonts for the monospaced font stack. But you're right, the change for the fixed family seems to not having been changed.

I was convinced, that when we updated the regular font stack, we also did for the fixed font-family, which was wrong. Hopefully that clarifies it.

Besides that, I'm still convinced that it made sense to do so now.

There's also a relatively new value called system-ui which unifies the apple-system and BlinkMacSystemFont value (see css-tricks article). Theoretically we could also drop "Segoe UI", "Noto Sans", since we don't support IE anymore.

It should also be sufficiently supported in non bleeding edge browsers.
https://caniuse.com/?search=system-ui

@flourish86 flourish86 force-pushed the fix/update-font-family-stacks branch from f230984 to cb9c8c6 Compare August 8, 2024 14:06
@flourish86 flourish86 force-pushed the fix/update-font-family-stacks branch from cb9c8c6 to c1b6f24 Compare August 8, 2024 14:08
@nilmerg
Copy link
Member

nilmerg commented Aug 13, 2024

Okay. I was just triggered by this allegation that wasn't backed by any references.

Anyway.

Supporting bleeding-edge font aliases is fine, there are fallbacks for this reason.
And of course, we can drop all IE related stuff. At least, we shouldn't introduce new IE only stuff. (i.e. Noto Sans)

@nilmerg nilmerg added area/ui Affects the user interface enhancement New feature or improvement labels Aug 13, 2024
@nilmerg nilmerg added this to the 2.12.2 milestone Aug 13, 2024
@nilmerg nilmerg modified the milestones: 2.12.2, 2.13 Nov 4, 2024
@nilmerg
Copy link
Member

nilmerg commented Nov 4, 2024

Quickly tested this and discussed this with @flourish86. Seems fine now, though I noticed that system-ui results in a way more bolder appearance of sidebar labels, which is why its font-weight needs to be decreased. Though this shows that we should thoroughly test this across OSes to make sure the impact isn't as bold. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Affects the user interface cla/signed enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants