VirtualMachine: if address state is optional

fixes #536

library/Vspheredb/DbObject/VirtualMachine.php

@@ -228,7 +228,19 @@ public function setNet($value)
  $addresses[$key]->addresses[] = (object) [
  'address' => $config->ipAddress,
  'prefixLength' => $config->prefixLength,
- 'state' => $config->state,
+ // state is not required, and is an IpAddressStatus enumeration:
+ // * deprecated Indicates that this is a valid but deprecated address that
+ // should no longer be used as a source address
+ // * duplicate Indicates the address has been determined to be non-unique
+ // on the link, this address will not be reachable.
+ // * inaccessible Indicates that the address is not accessible because
+ // interface is not operational
+ // * invalid Indicates that this isn't a valid
+ // * preferred Indicates that this is a valid address
+ // * tentative Indicates that the uniqueness of the address on the link
+ // is presently being verified
+ // * unknown Indicates that the status cannot be determined
+ 'state' => property_exists($config, 'state') ? $config->state : null,
  ];
  }
  }

library/Vspheredb/Web/Table/VmNetworkAdapterTable.php

@@ -91,7 +91,12 @@ protected function formatSimple($row)
  );
  $aIpInfo = [];
  foreach ($ipInfo->addresses as $address) {
- $aIpInfo[] = sprintf('%s/%s (%s)', $address->address, $address->prefixLength, $address->state);
+ // Explicit check for isset, as WP had a workaround skipping the property
+ if (! isset($address->state) || $address->state === null) {
+ $aIpInfo[] = sprintf('%s/%s', $address->address, $address->prefixLength);
+ } else {
+ $aIpInfo[] = sprintf('%s/%s (%s)', $address->address, $address->prefixLength, $address->state);
+ }
  }
  if (empty($aIpInfo)) {
  $aIpInfo = '';