Update CodeMirror and some fixes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before it overlapped with the edit/clone buttons. This change places it at the top of the page.
- Adding the btn-delete and btn-cancel classes to the respective buttons so that they are different from the confirmation buttons
- This change helps to avoid accidental deletion of YAML files
martialblog
force-pushed
the
feature/update-editor
branch
from
fd4b799
to
385f931
Compare
|
CI Actions are now and will be fixed in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CodeMirror 5 to latest version and add code folding, which helps when using the web editor on larger YAML files.
It also adds a small confirmation for the deletion of views.
Also changed the unsaved work warning position. Before it overlapped with the edit/clone buttons. This change places it at the top of the page.
Finally, fixed the icon change when collapsing a node