Handle long item names

[raviks789]

fixes #285

requires Icinga/ipl-web#182

[sukhwinder33445]

Breadcrumb still has the issue.

[raviks789]

Breadcrumb still has the issue.

Did you reload the page after switching to branch? As there are some css changes present.

[sukhwinder33445]

Breadcrumb still has the issue.

Did you reload the page after switching to branch? As there are some css changes present.

Yes, multiple times.

[sukhwinder33445]

• Please limit the Display Name.
• Center the tile's title.

[raviks789]

• Please limit the Display Name with the help of validator.

As discussed offline we will not be limiting Display Name length.

[sukhwinder33445]

• Please limit the Display Name with the help of validator.
• Center the tile's title.

[sukhwinder33445]

The span is not really required here.
Please add as following:

Suggested change

	Html::tag(
	'a',
	['href' => $bpUrl],
	HtmlElement::create('span', ['class' => 'text no-wrap', 'title' => $bp->getTitle()], $bp->getTitle())
	)
	Html::tag('a',
	['href' => $bpUrl, 'class' => ['text', 'no-wrap'], 'title' => $bp->getTitle()]],
	$bp->getTitle()
	)

• And you do not need the new classes, add the properties to anchor tag.

[raviks789]

For breadcrumbs the text is wrapped with span because overflow:hidden will also hide ::before and ::after content of anchor tag, that means the arrows of breadcrumbs will be hidden. But it makes sense not to wrap the text in node tiles.

[sukhwinder33445]

Breadcrumb still has the issue.

Still the same issue.

[raviks789]

Breadcrumb still has the issue.

Still the same issue.

Could you test it now?

[sukhwinder33445]

LGTM 🎉

[flourish86]

Looks fine to me.

[nilmerg]

Am I the only one who has a problem with the overflow in the tree view ??? Overtaking..

[nilmerg]

Overtaking...

Or not.

There are not even titles on the nodes upon hover. Only on the breadcrumb.

But I see no option to have this in the next release. So, don't hurry.