added remoteip to logging #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the contribution! Though this is a case where data retention policies of several countries and companies are involved, so we can't merge this right away at the moment. We'll think of how to enhance the audit module anyway in the coming weeks, so once we did that we'll continue here as well. |
|
What is the situation here? Can this be merged? There is still no IP in the audit log and we need that to prevent bruteforcing. |
Didn't happen.
No. Not unless it is configurable and opt-in only. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the Remote-IP to the Audit-Log. Useful for e.g. fail2ban.
Uses
HTTP_X_FORWARDED_FOR-Header if present, if not usesREMOTE_ADDR