Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA State: ensure not this and another instance can be responsible #825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/icingadb/ha.go
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@ func (h *HA) realize(

h.signalTakeover(takeover)
} else if otherResponsible {
if state := h.state.Load(); state.responsible {
h.logger.Error("Other instance is responsible while this node itself is responsible, dropping responsibility")
h.signalHandover("other instance is responsible as well")
// h.signalHandover will update h.state
}
if state := h.state.Load(); !state.otherResponsible {
// Dereference pointer to create a copy of the value it points to.
// Ensures that any modifications do not directly affect the original data unless explicitly stored back.
Expand Down
Loading