Skip to content

cmd/icingadb-migrate: replace magic number 20 with sha1.Size#769

Merged
oxzi merged 1 commit intoicingadb-migrate-check-env-id-lengthfrom
icingadb-migrate-check-env-id-length-sha1
Jul 9, 2024
Merged

cmd/icingadb-migrate: replace magic number 20 with sha1.Size#769
oxzi merged 1 commit intoicingadb-migrate-check-env-id-lengthfrom
icingadb-migrate-check-env-id-length-sha1

Conversation

@Al2Klimov
Copy link
Copy Markdown
Member

Test

bad env ID: must be 20 bytes long, has 21 bytes

👍

@Al2Klimov Al2Klimov added the bug Something isn't working label Jul 9, 2024
@Al2Klimov Al2Klimov requested a review from oxzi July 9, 2024 12:59
@cla-bot cla-bot bot added the cla/signed label Jul 9, 2024
@Al2Klimov
Copy link
Copy Markdown
Member Author

I'd let GH rebase-and-merge btw.

@oxzi oxzi merged commit b6839ce into icingadb-migrate-check-env-id-length Jul 9, 2024
@oxzi oxzi deleted the icingadb-migrate-check-env-id-length-sha1 branch July 9, 2024 13:30
@oxzi
Copy link
Copy Markdown
Member

oxzi commented Jul 9, 2024

FTR: Pull Request went against #768, not the main branch.

@oxzi oxzi added this to the 1.2.1 milestone Jul 30, 2024
@oxzi oxzi added the area/migrate cmd/icingadb-migrate label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/migrate cmd/icingadb-migrate bug Something isn't working cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants