Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micro optimizations #321

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Micro optimizations #321

wants to merge 6 commits into from

Conversation

lippserd
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla/signed label Oct 5, 2021
@julianbrost
Copy link
Contributor

@lippserd What's the future plan for this PR?

@lippserd
Copy link
Member Author

@lippserd What's the future plan for this PR?

Honestly, I don't know yet but I asked @Al2Klimov to test whether this PR does anything in terms of performance, cpu and memory usage.

@Al2Klimov
Copy link
Member

TODO

  • throw away everything not to be merged anyway (e.g. exit after config sync)
  • make CI/CD happy

@Al2Klimov
Copy link
Member

Tip: git push -f commit by commit sleeping 10s inbetween, so we see whose commits broke the CI/CD.

@lippserd
Copy link
Member Author

Tip: git push -f commit by commit sleeping 10s inbetween, so we see whose commits broke the CI/CD.

The new types from your commits don’t have the database interfaces implemented and thus the delete fails if I remember correctly.

@lippserd lippserd changed the title Performance Micro optimizations Nov 12, 2021
@lippserd lippserd removed their assignment Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lippserd @julianbrost @Al2Klimov