Hide unreachable parents in root problems

[nilmerg]

I am aware that the filter may cause services to disappear because their host is unreachable. But this is not a false positive, as implicit dependencies dictate that services of unreachable hosts are in turn as well unreachable. So whether such a service disappears because its host is unreachable or itself is, makes no difference.

[raviks789]

This change causes false negatives.

For example, if there is an explicit dependency between two services with same host, and the host is down, then both the services become unreachable but also the dependency fails. And this change would filter out the unreachable parent service, which should not happen.

See the screenshot below for one such case

[raviks789]

This change causes false negatives.

For example, if there is an explicit dependency between two services with same host, and the host is down, then both the services become unreachable but also the dependency fails. And this change would filter out the unreachable parent service, which should not happen.

This seems to apply to any service-to-service dependency. See the screenshot below.

So put it simply, if the host of the parent service is down, the parent service becomes unreachable. This in turn results in the dependency being failed. But according to the filter the parent service should be reachable.

Hence, it might also be safe to conclude there will be false negatives for service-to-host dependencies as well.

[nilmerg]

I fully reworked this. Please have a look at it again.

I used the following configuration for tests: (Each check rotates through every valid state, just use "Check Now" to change it. Though, don't forget to run icingacli icingadb dependency syncState ;) )

graph TD;
    A-->B;
    B-->D;
    C-->D;
    D-->H;
    F-->E;
    E-->G;
    G-->H;
    A-.->F;
    B-.->E;
    B-.->C;
    G-.->H;
    subgraph GD [ redundancy group ]
    G~~~D
   end

Loading

template Host "dbweb-1073-host" {
    import "generic-host"

    check_command = "dummy"
    check_interval = 365d
    retry_interval = 365d
    max_check_attempts = 1

    vars.issue_no = 1073

    vars.state_id = 0
    vars.states = [0, 2]

    var that = this
    vars.dummy_state = function () use (that) {
        var ret = that.vars.states[that.vars.state_id]

        that.vars.state_id += 1
        if (that.vars.state_id == len(that.vars.states)) {
            that.vars.state_id = 0
        }

        return ret
    }
}

template Service "dbweb-1073-service" {
    import "generic-service"

    check_command = "dummy"
    check_interval = 365d
    retry_interval = 365d
    max_check_attempts = 1

    vars.issue_no = 1073

    vars.state_id = 0
    vars.states = [0, 1, 2, 3]

    var that = this
    vars.dummy_state = function () use (that) {
        var ret = that.vars.states[that.vars.state_id]

        that.vars.state_id += 1
        if (that.vars.state_id == len(that.vars.states)) {
            that.vars.state_id = 0
        }

        return ret
    }
}

object Host "A" {
    import "dbweb-1073-host"
}

object Host "B" {
    import "dbweb-1073-host"
}

object Service "C" {
    import "dbweb-1073-service"

    host_name = "B"
}

object Host "D" {
    import "dbweb-1073-host"
}

object Service "E" {
    import "dbweb-1073-service"

    host_name = "B"
}

object Service "F" {
    import "dbweb-1073-service"

    host_name = "A"
}

object Host "G" {
    import "dbweb-1073-host"
}

object Service "H" {
    import "dbweb-1073-service"

    host_name = "G"
}

object Dependency "A-B" {
    parent_host_name = "A"
    child_host_name = "B"
}

object Dependency "B-D" {
    parent_host_name = "B"
    child_host_name = "D"
}

object Dependency "C-D" {
    parent_host_name = "B"
    parent_service_name = "C"
    child_host_name = "D"
}

object Dependency "F-E" {
    parent_host_name = "A"
    parent_service_name = "F"
    child_host_name = "B"
    child_service_name = "E"
}

object Dependency "E-G" {
    parent_host_name = "B"
    parent_service_name = "E"
    child_host_name = "G"
}

object Dependency "G-H" {
    parent_host_name = "G"
    child_host_name = "G"
    child_service_name = "H"

    redundancy_group = "GD"
}

object Dependency "D-H" {
    parent_host_name = "D"
    child_host_name = "G"
    child_service_name = "H"

    redundancy_group = "GD"
}