IcingaDB#SerializeState(): limit execution_time and latency to 2^32-1 #10060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
reviewed
May 15, 2024
Al2Klimov
force-pushed
the
IcingaDB-SerializeState-execution_time-latency
branch
from
3cc3b4e
to
3318871
Compare
not to write higher values into Redis than the Icinga DB schema can hold. This fixes yet another potential Go daemon crash.
Al2Klimov
force-pushed
the
IcingaDB-SerializeState-execution_time-latency
branch
from
3318871
to
f9adf18
Compare
julianbrost
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Can be tested by submitting a passive check result that triggers a state change and a execution_end more than date +%s -d +100days) and no execution_start to test the case for execution_latency. The other case can be tested by just setting execution_end to the same value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not to write higher values into Redis than the Icinga DB schema can hold. This fixes yet another potential Go daemon crash.
ref/IP/53518
CC @RincewindsHat