You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Doesn't work yet. Autoloading is messed up. Composer usually takes care of dependency resolution during autoloading. But by faking them here using the repl/acer library, composer thinks they are available. This then leads to problems with e.g. ipl/scheduler which contains a file autoloader that expects a particular dependency being available while it runs. And it runs right away if Icinga Web requires the ipl's vendor/autoload.php. (Which might happen before icinga-php-thirdparty's autoloader is required)
We need our own dependency resolution for libraries. ipl could define the following in composer.json:
And no, changing ipl/scheduler file autoloader doesn't help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes Icinga/ipl-scheduler#49