Sync container logs #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
logs
branch
5 times, most recently
from
5da9bc0
to
4ce99a2
Compare
lippserd
requested changes
Nov 28, 2023
jrauh01
force-pushed
the
logs
branch
2 times, most recently
from
d7f236a
to
d7794a6
Compare
lippserd
requested changes
Nov 29, 2023
There was a problem hiding this comment.
In addition to the requested changes please also double check your doc comments after reading https://tip.golang.org/doc/comment carefully.
lippserd
requested changes
Nov 29, 2023
jrauh01
changed the title
lippserd
requested changes
Dec 8, 2023
jrauh01
force-pushed
the
logs
branch
2 times, most recently
from
9e392de
to
a0511d4
Compare
lippserd
requested changes
Dec 12, 2023
lippserd
requested changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to sync container logs to database.