Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/285/customgallery #368

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

newhinton
Copy link

This implements #285

@newhinton newhinton marked this pull request as draft March 13, 2024 10:59
@newhinton
Copy link
Author

newhinton commented Mar 13, 2024

@IacobIonut01

I have now implemented the core functionality of custom albums. They are based on the original albums, and not every feature works. (Eg. pinning, album previews)

Besides a code-review, there is also a bit of cleanup todo, especially for the strings, since i changed albums to folders. There are probably quite a few missing. My reasoning for this is that it makes more sense, since it actually behaves exactly like the folders in a files app. Also, having three different "album" types might be confusing (Folders, custom albums, dynamic albums)

@newhinton newhinton marked this pull request as ready for review March 13, 2024 12:09
@IacobIonut01
Copy link
Owner

I'll review this weekend and do the changes accordingly. Thanks

@IacobIonut01
Copy link
Owner

IacobIonut01 commented Mar 22, 2024

Opening media inside the custom albums also don't work

@newhinton
Copy link
Author

Opening media inside the custom albums also don't work

Oh yeah, i can see that. I'll take a look later!

@newhinton
Copy link
Author

Hm, i only used the TimelineScreen like the album does. I cant see whats wrong, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants