-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFDI4Chem TS #48
base: main
Are you sure you want to change the base?
NFDI4Chem TS #48
Conversation
Contribution via issue #43
as the interdependencies between terminologies, to make informed decisions. Although there are many sophisticated | ||
terminology services available, such as the [Basic Register of Thesauri, Ontologies & Classifications (BARTOC)](https://bartoc.org/) | ||
or the [Ontology Lookup Service (OLS)](https://www.ebi.ac.uk/ols4), they contain a large selection of different terminologies and ontologies | ||
that can overwhelm domain experts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Overwhelm domain experts' seems like quite a sweeping statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Sentence reformulated as follows:
"Despite the existence of sophisticated terminology services such as the Basic Register of Thesauri, Ontologies & Classifications (BARTOC) or the Ontology Lookup Service (OLS), the vast array of terminologies and ontologies they encompass makes it challenging for domain experts to identify the most relevant and suitable ones for their specific use cases."
Hope this fits better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this screen shot is high enough resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provided new file for fig1
To implement the search example above in Python using the NFDI4Chem TS API, follow these steps: | ||
|
||
``` | ||
import requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuchalk to review code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Smund27 I have just added a Python file with an update of the code in this contribution. The code would not execute without an update. The following updates have been included:
- updated line 7 to import urllib.parse
- reformatted code with appropriate indention to execute correctly
- added doc strings to describe the code in accordance with PEP 257 (Docstring Conventions)
- checked the code for style conventions per PEP-8 (Style Guide for Python)
- commented out the last function in the ChemSearch class as it does not seem to be necessary as part of the example, and it is not clear as to what it accomplishes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced the code in the contribution with the code provided in the Python file by Stuart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stuarts new code looks much better suited for the cookbook.
Contribution via issue #43