Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFDI4Chem TS #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NFDI4Chem TS #48

wants to merge 3 commits into from

Conversation

stuchalk
Copy link
Member

Contribution via issue #43

Contribution via issue #43
@stuchalk stuchalk added the contribution A new proposed addition to the cookbook label Feb 28, 2024
@stuchalk stuchalk self-assigned this Feb 28, 2024
as the interdependencies between terminologies, to make informed decisions. Although there are many sophisticated
terminology services available, such as the [Basic Register of Thesauri, Ontologies & Classifications (BARTOC)](https://bartoc.org/)
or the [Ontology Lookup Service (OLS)](https://www.ebi.ac.uk/ols4), they contain a large selection of different terminologies and ontologies
that can overwhelm domain experts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Overwhelm domain experts' seems like quite a sweeping statement

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Sentence reformulated as follows:
"Despite the existence of sophisticated terminology services such as the Basic Register of Thesauri, Ontologies & Classifications (BARTOC) or the Ontology Lookup Service (OLS), the vast array of terminologies and ontologies they encompass makes it challenging for domain experts to identify the most relevant and suitable ones for their specific use cases."

Hope this fits better now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this screen shot is high enough resolution

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provided new file for fig1

To implement the search example above in Python using the NFDI4Chem TS API, follow these steps:

```
import requests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuchalk to review code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Smund27 I have just added a Python file with an update of the code in this contribution. The code would not execute without an update. The following updates have been included:

  • updated line 7 to import urllib.parse
  • reformatted code with appropriate indention to execute correctly
  • added doc strings to describe the code in accordance with PEP 257 (Docstring Conventions)
  • checked the code for style conventions per PEP-8 (Style Guide for Python)
  • commented out the last function in the ChemSearch class as it does not seem to be necessary as part of the example, and it is not clear as to what it accomplishes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced the code in the contribution with the code provided in the Python file by Stuart

Copy link
Collaborator

@Smund27 Smund27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuarts new code looks much better suited for the cookbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution A new proposed addition to the cookbook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants