Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 add constrains in resource_tracker_pricing_plan_to_service and licensed_item_to_resource DB tables (πŸ—ƒοΈ) #7269

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Feb 25, 2025

What do these changes do?

  • 🎨 add ondelete restriction to pricing plan to service DB table (πŸ—ƒοΈ)
  • 🎨 add unqiue constrain on licensed resource ID in the licensed_item_to_resource DB table (πŸ—ƒοΈ)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:database associated to postgres service and postgres-database package label Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the The Awakening milestone Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 25, 2025 08:27
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 25, 2025 08:27
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 88.58%. Comparing base (e7e0b79) to head (81d1663).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7269      +/-   ##
==========================================
+ Coverage   85.33%   88.58%   +3.24%     
==========================================
  Files        1686     1431     -255     
  Lines       65349    56708    -8641     
  Branches     1115      540     -575     
==========================================
- Hits        55764    50233    -5531     
+ Misses       9267     6324    -2943     
+ Partials      318      151     -167     
Flag Coverage Ξ”
integrationtests 65.31% <ΓΈ> (-0.12%) ⬇️
unittests 87.69% <ΓΈ> (+3.57%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 91.56% <ΓΈ> (ΓΈ)
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.28% <ΓΈ> (ΓΈ)
pkg_service_integration βˆ… <ΓΈ> (βˆ…)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.08% <ΓΈ> (ΓΈ)
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.56% <ΓΈ> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 91.73% <ΓΈ> (ΓΈ)
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.25% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 76.59% <ΓΈ> (-0.10%) ⬇️
director_v2 91.27% <ΓΈ> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.74% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 88.97% <ΓΈ> (-0.11%) ⬇️
storage 86.65% <ΓΈ> (-0.06%) ⬇️
webclient βˆ… <ΓΈ> (βˆ…)
webserver 84.61% <ΓΈ> (+5.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update e7e0b79...81d1663. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 add ondelete restriction to pricing plan to service DB table (πŸ—ƒοΈ) 🎨 add constrains in resource_tracker_pricing_plan_to_service and licensed_item_to_resource DB tables (πŸ—ƒοΈ) Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 25, 2025 09:24
@matusdrobuliak66 matusdrobuliak66 merged commit 603a27d into ITISFoundation:master Feb 25, 2025
91 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-sql-constrain branch February 25, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants