Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improves empty-trash to avoid misleading the user #7267

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 24, 2025

What do these changes do?

Prevents that when the front-end requests empty-trash and subsequently requests the trash item list, it may still display items, misleading the user into thinking the empty trash operation failed.

Related issue/s

How to test

Manually tested:

  • trash many items
  • Go to "Recently Deleted"
  • Click Delete all
    image
  • shows none
    image

Dev-ops

@pcrespov pcrespov self-assigned this Feb 24, 2025
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Feb 24, 2025
@pcrespov pcrespov added this to the The Awakening milestone Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (e3fdf00) to head (fbc692d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7267      +/-   ##
==========================================
- Coverage   86.97%   83.38%   -3.60%     
==========================================
  Files        1686      655    -1031     
  Lines       65343    31674   -33669     
  Branches     1115      177     -938     
==========================================
- Hits        56834    26410   -30424     
+ Misses       8191     5202    -2989     
+ Partials      318       62     -256     
Flag Coverage Δ
integrationtests 65.43% <14.28%> (+0.01%) ⬆️
unittests 86.14% <100.00%> (+0.15%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.25% <ø> (-7.83%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.53% <ø> (-12.76%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 84.61% <100.00%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fdf00...fbc692d. Read the comment docs.

@pcrespov pcrespov changed the title WIP: 🎨 Improves empty-trash to avoid misleading the user 🎨 Improves empty-trash to avoid misleading the user Feb 24, 2025
@pcrespov pcrespov marked this pull request as ready for review February 24, 2025 12:15
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is468/empty-trash-masks-before-responding branch from 2176b8e to fbc692d Compare February 24, 2025 17:36
@pcrespov pcrespov enabled auto-merge (squash) February 24, 2025 17:37
@pcrespov pcrespov merged commit e7e0b79 into ITISFoundation:master Feb 25, 2025
90 of 95 checks passed
@pcrespov pcrespov deleted the is468/empty-trash-masks-before-responding branch February 25, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants