-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improves empty-trash to avoid misleading the user #7267
🎨 Improves empty-trash to avoid misleading the user #7267
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7267 +/- ##
==========================================
- Coverage 86.97% 83.38% -3.60%
==========================================
Files 1686 655 -1031
Lines 65343 31674 -33669
Branches 1115 177 -938
==========================================
- Hits 56834 26410 -30424
+ Misses 8191 5202 -2989
+ Partials 318 62 -256
Continue to review full report in Codecov by Sentry.
|
services/web/server/src/simcore_service_webserver/trash/_rest.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
services/web/server/src/simcore_service_webserver/trash/_rest.py
Outdated
Show resolved
Hide resolved
2176b8e
to
fbc692d
Compare
|
What do these changes do?
Prevents that when the front-end requests
empty-trash
and subsequently requests the trash item list, it may still display items, misleading the user into thinking theempty trash
operation failed.Related issue/s
How to test
Manually tested:
Delete all
Dev-ops