-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ♻️ mai/refactor products #7263
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
===========================================
- Coverage 87.17% 69.93% -17.24%
===========================================
Files 1680 757 -923
Lines 65053 34301 -30752
Branches 1106 180 -926
===========================================
- Hits 56709 23989 -32720
- Misses 8030 10252 +2222
+ Partials 314 60 -254
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
694fdaa
to
4976951
Compare
64b79d8
to
07d794e
Compare
07d794e
to
db2c77c
Compare
|
What do these changes do?
This PR refactors
simcore_service_webserver.products
domain and extends its test coverage over 90%♻️ refactors
simcore_service_webserver.products
package skeleton to fit_rest
_invitation_rest
->invitations
domain_rpc
_repository
asyncpg
_service
,products_service
(public)_models
,models
(public)Annotated
web
_web_events
:web.Application
slots_web_middlewares
:web.Application
middlewares_web_helpers
: helpers that wraps service layer on anaiohttp.web
inteface.products_web
(public): access to some of the helpersplugin
products
codeThis is how the public inteface of this domain is suppose to be used
🔨 enhances
pytest_simcore.pydantic_models
helpersEnhances
pytest_simcore.pydantic_models
helpers to parametrize tests of examples from a package, module or class level usingiter_model_examples_in_*
iterators.assert_validation_model
does all the standard test on the examples as well.Related issue/s
How to test
Driving test
Dev-ops
None