-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Storage: new paths entrypoint with pagination #7200
base: master
Are you sure you want to change the base?
✨Storage: new paths entrypoint with pagination #7200
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7200 +/- ##
===========================================
- Coverage 87.17% 59.97% -27.21%
===========================================
Files 1680 730 -950
Lines 65053 32778 -32275
Branches 1106 12 -1094
===========================================
- Hits 56709 19658 -37051
- Misses 8030 13118 +5088
+ Partials 314 2 -312
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
5672008
to
ccaff88
Compare
7ab8d54
to
02ebf8d
Compare
9bde281
to
8411473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot 👌
a74a198
to
aad652b
Compare
|
What do these changes do?
reminder: storage caches partially the files in S3 in the DB.
Summary
This PR adds a new entrypoint in storage that allows to list files/folders (both inside DB/S3) with pagination.
Webserver API
GET /storage/locations/{location_id}/paths
withfile_filter
query parameterfile_filter
is null then this will list the projects that have files,file_filter
is some specific project ID, then it will list the nodes with files inside that project,file_filter
isPROJECTID/NODEID
then it will list the files/folders in that node that have files in them,Storage Rest API
test_handler_paths.py
Pagination
GET /storage/locations/{location_id}/paths
can havelimit
andcursor
query parameterscursor
set to null or not passednext_page
(the next cursor), that shall be passed with the next call toGET /storage/locations/{location_id}/paths
to get the next pageAWS-library
test_s3_client.py
Requirements
Next steps
Related issue/s
How to test
Dev-ops checklist