-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ✨ Is7097/fetch vip api 🗃️ 🚨 #7140
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7140 +/- ##
==========================================
+ Coverage 84.70% 88.83% +4.12%
==========================================
Files 1393 1422 +29
Lines 56986 56920 -66
Branches 909 695 -214
==========================================
+ Hits 48271 50564 +2293
+ Misses 8473 6189 -2284
+ Partials 242 167 -75
Continue to review full report in Codecov by Sentry.
|
8fac934
to
f266505
Compare
17762ce
to
77be4fc
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Fetches models published in vip-api, validates them and syncs with items already in
licensed_items
🗃️
postgres-database
licensed_items
:licensed_resource_data
andtrashed
product_name
andpricing_plan_id
nullable. This is how we identify which of the items are ready or notsteps
items_licensed
, e.g.licensed_resource_data
includes category, description etc(VIP_MODEL, $category/$ID)
leaving product,pricing_plan until human activates it.licensed_resource_data
so front-end can display catalogRelated issue/s
licensed_items
table #7097How to test
Driving tests
Dev-ops
product_name
) and princing plans (pricing_plan_id
)