Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Changing Rest Model for licensed items listing (πŸ—ƒοΈ) #7139

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

🎨 Changing Rest Model for licensed items listing (πŸ—ƒοΈ) #7139

wants to merge 20 commits into from
+395 βˆ’181

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jan 29, 2025 •
edited
Loading

What do these changes do?

  • 🎨 Changing Rest Model for licensed items listing (πŸ—ƒοΈ)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 29, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.57%. Comparing base (b837ee0) to head (39c4581).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7139      +/-   ##
==========================================
+ Coverage   84.70%   87.57%   +2.86%     
==========================================
  Files        1393     1575     +182     
  Lines       56986    62325    +5339     
  Branches      909     1086     +177     
==========================================
+ Hits        48271    54578    +6307     
+ Misses       8473     7457    -1016     
- Partials      242      290      +48
Flag Coverage Ξ”
integrationtests 64.68% <69.69%> (+0.01%) ⬆️
unittests 85.82% <86.25%> (+2.68%) ⬆️
Components Coverage Ξ”
api 76.84% <ΓΈ> (ΓΈ)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 91.51% <94.73%> (+0.02%) ⬆️
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.39% <ΓΈ> (βˆ…)
pkg_service_integration 70.18% <ΓΈ> (βˆ…)
pkg_service_library 74.39% <0.00%> (ΓΈ)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.50% <ΓΈ> (+7.95%) ⬆️
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.55% <100.00%> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 90.33% <ΓΈ> (ΓΈ)
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.26% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 76.92% <ΓΈ> (ΓΈ)
director_v2 91.30% <ΓΈ> (+0.04%) ⬆️
dynamic_scheduler 97.21% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.75% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (βˆ…)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 89.06% <ΓΈ> (βˆ…)
storage 89.57% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 86.20% <87.87%> (+8.68%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b837ee0...39c4581. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 WIP: VIP model πŸ—ƒοΈ 🎨 Changing Rest Model for licensed listing (πŸ—ƒοΈ) Jan 30, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 30, 2025 15:19
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Changing Rest Model for licensed listing (πŸ—ƒοΈ) 🎨 Changing Rest Model for licensed items listing (πŸ—ƒοΈ) Jan 30, 2025
odeimaiz
odeimaiz reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend changes will follow πŸ‘

pcrespov
pcrespov approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider the comments. we interact offline if you have any questions/discussion

api/specs/web-server/_licensed_items.py Show resolved Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py Show resolved Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py Show resolved Hide resolved
packages/models-library/src/models_library/utils/common_validators.py Show resolved Hide resolved
...se/src/simcore_postgres_database/migration/versions/b8e3837d8d87_modify_licensed_items_db.py Outdated Show resolved Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_common/models.py Outdated Show resolved Hide resolved
services/web/server/tests/unit/with_dbs/04/licenses/test_licensed_items_repository.py Outdated Show resolved Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz left review comments

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@mguidon mguidon Awaiting requested review from mguidon

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matusdrobuliak66 @giancarloromeo @pcrespov @odeimaiz @sanderegg