improvements

ITISFoundation · Feb 25, 2025 · 438da41 · 438da41
1 parent 13492e8
commit 438da41
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/packages/pytest-simcore/src/pytest_simcore/helpers/httpx_assert_checks.py b/packages/pytest-simcore/src/pytest_simcore/helpers/httpx_assert_checks.py
@@ -32,7 +32,7 @@ def assert_status(
         response.status_code == expected_status_code
     ), f"received {response.status_code}: {response.text}, expected {get_code_display_name(expected_status_code)}"
 
-    # reponse
+    # response
     if expected_status_code == status.HTTP_204_NO_CONTENT:
         assert response.text == ""
         return None, None

diff --git a/packages/service-library/src/servicelib/fastapi/http_error.py b/packages/service-library/src/servicelib/fastapi/http_error.py
@@ -99,3 +99,17 @@ def set_app_default_http_error_handlers(app: FastAPI) -> None:
             envelope_error=True,
         ),
     )
+
+    # SEE https://docs.python.org/3/library/exceptions.html#exception-hierarchy
+    app.add_exception_handler(
+        NotImplementedError,
+        make_http_error_handler_for_exception(
+            status.HTTP_501_NOT_IMPLEMENTED, NotImplementedError, envelope_error=True
+        ),
+    )
+    app.add_exception_handler(
+        Exception,
+        make_http_error_handler_for_exception(
+            status.HTTP_500_INTERNAL_SERVER_ERROR, Exception, envelope_error=True
+        ),
+    )
diff --git a/services/storage/src/simcore_service_storage/exceptions/handlers.py b/services/storage/src/simcore_service_storage/exceptions/handlers.py
@@ -94,17 +94,3 @@ def set_exception_handlers(app: FastAPI) -> None:
             envelope_error=True,
         ),
     )
-
-    # SEE https://docs.python.org/3/library/exceptions.html#exception-hierarchy
-    app.add_exception_handler(
-        NotImplementedError,
-        make_http_error_handler_for_exception(
-            status.HTTP_501_NOT_IMPLEMENTED, NotImplementedError, envelope_error=True
-        ),
-    )
-    app.add_exception_handler(
-        Exception,
-        make_http_error_handler_for_exception(
-            status.HTTP_500_INTERNAL_SERVER_ERROR, Exception, envelope_error=True
-        ),
-    )