Add ruff #642
Merged
Add ruff #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
force-pushed
the
add-ruff
branch
2 times, most recently
from
3a2ac78 to
dd4a7ad
Compare
MBartkowiakSTFC
approved these changes
Jan 27, 2025
oerc0122#1 needs to be merged into this first, but it's a significant chunk of (hopefully) whitespace-only changes. |
oerc0122
force-pushed
the
add-ruff
branch
6 times, most recently
from
0e1c40b to
28db251
Compare
oerc0122
commented
Jan 30, 2025
| @@ -165,7 +165,7 @@ def finalize(self): | |||
|
|
|||
| if self.configuration["normalize"]["value"]: | |||
| for element in nAtomsPerElement.keys(): | |||
| if self._outputData["gacf_{}}".format(element)][0] == 0: | |||
| if self._outputData[f"gacf_{element}}}"][0] == 0: | |||
There was a problem hiding this comment.
Is that extraneous bracket meant to be there?
There was a problem hiding this comment.
No, it should be removed.
oerc0122
force-pushed
the
add-ruff
branch
6 times, most recently
from
de4828c to
85abb15
Compare
|
I checked this one again. I think it is fine to be merged. |
oerc0122
force-pushed
the
add-ruff
branch
2 times, most recently
from
c409300 to
cbca21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Add ruff linting to CI and fix issues raised.
Fixes
Issues raised by ruff defaults.
To test
Standard tests should run.