-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rob/mdanse trajectory filter #615
Open
RobBuchananCompPhys
wants to merge
100
commits into
protos
Choose a base branch
from
rob/mdanse-trajectory-filter
base: protos
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+12,090
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiCheng45
reviewed
Dec 17, 2024
ChiCheng45
reviewed
Dec 17, 2024
MDANSE/Src/MDANSE/Framework/Configurators/TrajectoryFilterConfigurator.py
Outdated
Show resolved
Hide resolved
ChiCheng45
reviewed
Dec 17, 2024
ChiCheng45
reviewed
Dec 17, 2024
ChiCheng45
reviewed
Dec 17, 2024
ChiCheng45
reviewed
Dec 17, 2024
ChiCheng45
reviewed
Dec 19, 2024
…ydrogen) atomic trajectory csv data for testing
…tion of filter object
…attenuation + fix freq -> energy conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
TODO:
(Probably don't need to solve all of these immediately - some may become issues for further work after this is completed)
UI
UI &/or Backend
Backend
Tests
Other
Fixes
A list of fixes.
To test
Please describe the tests that were run to verify the changes.