-
Notifications
You must be signed in to change notification settings - Fork 505
IQSS/10680-Bagit warning fix #11416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qqmyers
wants to merge
4
commits into
IQSS:develop
Choose a base branch
from
QualitativeDataRepository:IQSS/10680-BagitFix
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IQSS/10680-Bagit warning fix #11416
qqmyers
wants to merge
4
commits into
IQSS:develop
from
QualitativeDataRepository:IQSS/10680-BagitFix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
reviewed
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good.
Co-authored-by: Philip Durbin <[email protected]>
pdurbin
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but the change makes sense and the docs (the release note) look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 21
FY25 Sprint 21 (2025-04-09 - 2025-04-23)
Size: 3
A percentage of a sprint. 2.1 hours.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When the way of configuring Archival Bag info was changed in #10122/v6.1, one use of the old bagit.SourceOrganization bundle string was missed. I copied the fix from QDR.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Set up archival bags - (perhaps coord with @Saixel who needs this for CAFE?) and verify that there is no warning as described in the issue and the Internal-Sender-Identifier: value in the bag info file has the value from the JvmSettings.BAGIT_SOURCE_ORG_NAME setting (with " Catalog" appended).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: