Skip to content

IQSS/10680-Bagit warning fix #11416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Apr 9, 2025

What this PR does / why we need it: When the way of configuring Archival Bag info was changed in #10122/v6.1, one use of the old bagit.SourceOrganization bundle string was missed. I copied the fix from QDR.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: Set up archival bags - (perhaps coord with @Saixel who needs this for CAFE?) and verify that there is no warning as described in the issue and the Internal-Sender-Identifier: value in the bag info file has the value from the JvmSettings.BAGIT_SOURCE_ORG_NAME setting (with " Catalog" appended).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@qqmyers qqmyers moved this to Ready for Review ⏩ in IQSS Dataverse Project Apr 9, 2025
@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Apr 9, 2025
@qqmyers qqmyers added this to the 6.7 milestone Apr 9, 2025
@coveralls
Copy link

coveralls commented Apr 9, 2025

Coverage Status

coverage: 23.007%. remained the same
when pulling 1b4b1d7 on QualitativeDataRepository:IQSS/10680-BagitFix
into cd48216 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good.

@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 9, 2025
@cmbz cmbz added the FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) label Apr 9, 2025
@qqmyers qqmyers removed their assignment Apr 10, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the change makes sense and the docs (the release note) look good.

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Apr 14, 2025
@pdurbin pdurbin removed their assignment Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 21 FY25 Sprint 21 (2025-04-09 - 2025-04-23) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Missing Bundle Property WARNING in logs During Bagit
4 participants