-
Notifications
You must be signed in to change notification settings - Fork 505
10520 dataset type licenses #11385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
10520 dataset type licenses #11385
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I left some feedback.
<c:if test="#{datasetPage}"> | ||
<f:selectItems value="#{DatasetPage.availableLicenses}" | ||
var="license" itemLabel="#{DatasetUtil:getLocalizedLicenseDetails(license, 'NAME')}" itemValue="#{license}"/> | ||
</c:if> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I trigger this new availableLicenses logic in the JSF UI? We don't have any way to pass the dataset type in to JSF, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you would have to create the dataset via the api with json that includes a datasetType
createDatasetResponse.prettyPrint(); | ||
|
||
|
||
createDatasetResponse.then().assertThat().statusCode(CREATED.getStatusCode()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. Shouldn't this be a failure instead of CREATED? The only available license is CC0 1.0 but in the JSON "CC BY 4.0" is passed in. Shouldn't it complain that you have to pass CC0 1.0?
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Philip Durbin <[email protected]>
Co-authored-by: Philip Durbin <[email protected]>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for QA so I'm approving this.
@sekmiller please keep an eye on the crazy RemoteOverlayAccessIOTest.testRemoteOverlayFiles:103 expected: <true> but was: <false>
error I showed you: https://github.com/IQSS/dataverse/actions/runs/14496860036/job/40666682581?pr=11385 . I'm not sure why I'm seeing it. Update: @qqmyers wrote about this in Slack. Someone needs to switch from that test from https://data.qdr.syr.edu/resources to another server.
Recent API test runs on Jenkins have been passing. That's good.
What this PR does / why we need it: Adds the ability to set licenses available to dataset types as a subset of the licenses available at the installation level. Part of GREI implementation
Which issue(s) this PR closes:
Special notes for your reviewer:
Not much UI action, though I added a filter on the edit dataset terms for when there may be limited licenses available.
Suggestions on how to test this:
Add a dataset type via superuser api. Licenses can be added at create or by update api. Datasets added via api with a dataset type must have a license that is available for that dataset type. If not the license will be set to null. In the edit terms UI the only available licenses should be those available to the dataset type. If the type does not define available licenses then all active licenses should be available.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
On edit dataset terms the licenses will be limited to those defined for the given dataset type of the dataset being edited.
Is there a release notes update needed for this change?:
included
Additional documentation:
Docs updated to reflect the changes.