Merged
Conversation
MQTT currently just a stub Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
Signed-off-by: Lance-Drane <Lance-Drane@users.noreply.github.com>
marshallmcdonnell
approved these changes
Sep 9, 2025
Contributor
marshallmcdonnell
left a comment
marshallmcdonnell
left a comment
There was a problem hiding this comment.
LGTM! I'm learning Rust more and more :) Thank you!
Merge whenever you are ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds MQTT support to the proxy server/client while also maintaining AMQP support. This necessitated refactoring the application to utilize several protocol-based traits, but the refactor should make it easier to add additional protocols as necessary.
Configuration
adds an additional
protocolfield to the config file (both client and server) under thebrokersection, use eitheramqpormqtt.Resiliency
The MQTT protocol should act similar to the AMQP protocol:
- if unable to connect to the broker on startup, terminate the application immediately. Likely indicates incorrect credentials
- if disconnected from the broker as part of normal application flow, keep the application alive so it can potentially reconnect to the broker.
Limitations
The current MQTT implementation will always auto-acknowledge messages. This is different from the AMQP implementation, where we manually acknowledge messages (we requeue messages which didn't get through due to a server-side error, and accept all other messages). The MQTT implementation should be resilient enough, but messages which fail to propagate to the other proxy will be lost.