Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning rate explanation #800

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

fritshermans
Copy link
Contributor

@fritshermans fritshermans commented Jan 28, 2025

Fixes #798.

This PR corrects the explanation of the learning_rate parameter in GBDT models.

Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue @fritshermans. Just a couple of wording tweaks.

@ArturoAmorQ
Copy link
Collaborator

Thanks again @fritshermans, merging!

On a side comment, hitting 800 in the github counter is quite a milestone 🎉

@ArturoAmorQ ArturoAmorQ merged commit 528917e into INRIA:main Jan 29, 2025
3 checks passed
@fritshermans fritshermans deleted the learning_rate_explanation branch January 30, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct explanation of learning_rate
2 participants